Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Treat quote as value if already in quote using another delimiter #226

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

silvadiego
Copy link

Fixes the issue as described in #222.

@glensc
Copy link
Contributor

glensc commented Mar 18, 2019

@silvadiego is this same problem? can you cherry-pick testcase from there?

<?php
/**
* @see https://github.com/zendframework/zend-mail for the canonical source repository
* @copyright Copyright (c) 2005-2018 Zend Technologies USA Inc. (https://www.zend.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019 perhaps?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silvadiego is this same problem? can you cherry-pick testcase from there?

Yes, i will do that when i get home.

@glensc
Copy link
Contributor

glensc commented Mar 21, 2019

not sure, should #224 be added to changelog too? but at least include #222 in changelog!

@glensc
Copy link
Contributor

glensc commented May 2, 2019

@weierophinney can we get this merged?

as noted in #224, this is regression from changes from #147 resolution i.e from your 8aac5f7 commit

glensc added a commit to eventum/zend-mail that referenced this pull request May 2, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
@glensc
Copy link
Contributor

glensc commented Jul 6, 2019

@Xerkus ping?

@glensc
Copy link
Contributor

glensc commented Jul 8, 2019

@silvadiego I don't know what's this project merge policy (hardly anybody accepts changes here), but good practice is to squash useless commits to one commit and git push -f (three commits altering changelogs could be squashed)

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#18.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants