Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat quote as value if already in quote using another delimiter #18

Closed
weierophinney opened this issue Dec 31, 2019 · 6 comments · Fixed by #75
Closed

Treat quote as value if already in quote using another delimiter #18

weierophinney opened this issue Dec 31, 2019 · 6 comments · Fixed by #75
Labels
Bug Something isn't working
Milestone
2.10.1

Comments

@weierophinney
Copy link
Member

weierophinney commented Dec 31, 2019 •
edited by michalbundyra
Loading

Fixes the issue as described in zendframework/zend-mail#222.

Originally posted by @silvadiego at zendframework/zend-mail#226
@weierophinney
Copy link
Member Author

@silvadiego is this same problem? can you cherry-pick testcase from there?

Originally posted by @glensc at zendframework/zend-mail#226 (comment)

@weierophinney
Copy link
Member Author

weierophinney commented Dec 31, 2019 •
edited by michalbundyra
Loading

not sure, should zendframework/zend-mail#224 be added to changelog too? but at least include zendframework/zend-mail#222 in changelog!

Originally posted by @glensc at zendframework/zend-mail#226 (comment)

@weierophinney
Copy link
Member Author

@weierophinney can we get this merged?

as noted in zendframework/zend-mail#224, this is regression from changes from zendframework/zend-mail#147 resolution i.e from your zendframework/zend-mail@8aac5f7 commit

Originally posted by @glensc at zendframework/zend-mail#226 (comment)

@weierophinney
Copy link
Member Author

@Xerkus ping?

Originally posted by @glensc at zendframework/zend-mail#226 (comment)

@weierophinney
Copy link
Member Author

@silvadiego I don't know what's this project merge policy (hardly anybody accepts changes here), but good practice is to squash useless commits to one commit and git push -f (three commits altering changelogs could be squashed)

Originally posted by @glensc at zendframework/zend-mail#226 (comment)

@weierophinney weierophinney mentioned this issue Dec 31, 2019
Open
@silvadiego silvadiego mentioned this issue Jan 29, 2020
Merged
@michalbundyra michalbundyra linked a pull request Apr 1, 2020 that will close this issue
Treat quote as value if already in quote using another delimiter #75
Merged
@michalbundyra michalbundyra added the Bug Something isn't working label Apr 1, 2020
@michalbundyra michalbundyra added this to the 2.10.1 milestone Apr 1, 2020
@glensc
Copy link
Contributor

glensc commented Aug 6, 2020

@weierophinney please edit issue body to fix ticket link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.10.1
Development

Successfully merging a pull request may close this issue.

Treat quote as value if already in quote using another delimiter silvadiego/laminas-mail
3 participants
@weierophinney @glensc @michalbundyra