Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Guidance: Update usability guidance for Date Picker and Date Range Picker #2822

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

USWDS-Site - Guidance: Update usability guidance for Date Picker and Date Range Picker #2822

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f61367b
Add usability guidance to datepicker and date range picker.
cathybaptista Sep 11, 2024
118eac8
add changelogs for updated date range picker and date picker guidance.
cathybaptista Sep 13, 2024
d7ec2fa
removed newline at line 2.
cathybaptista Sep 13, 2024
1d6de11
addint the changelog information to this branch.
cathybaptista Sep 16, 2024
afb03a6
modification to changelogs so wording is clearer; remove reference to…
cathybaptista Sep 16, 2024
ce5d005
making sure this branch is up to date.
cathybaptista Sep 16, 2024
6935aa4
Update component-date-picker.yml
annepetersen Sep 17, 2024
39e98d0
Update component-date-range-picker.yml
annepetersen Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _components/date-picker/guidance/usability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- **Describe the date format.** Provide a hint of `mm/dd/yyyy` to help users enter the proper date format if they opt not to use the date picker.
- **Describe the date format.** Provide a hint of `mm/dd/yyyy` to help users enter the proper date format if they opt not to use the date picker.
- **Always allow a user to type in the date manually.** Usability testing suggests some people prefer manually typing the date rather than using the calendar picker. Whenever possible, keep the keyboard active so people can enter in the date information without having to use the picker.
3 changes: 2 additions & 1 deletion _components/date-range-picker/guidance/usability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- **Describe the date format.** Provide a hint of `mm/dd/yyyy` to help users enter the proper date format if they opt not to use the date picker.
- **Describe the date format.** Provide a hint of `mm/dd/yyyy` to help users enter the proper date format if they opt not to use the date picker.
- **Always allow a user to type in the date manually.** Usability testing suggests some people prefer manually typing the date rather than using the calendar picker. Whenever possible, keep the keyboard active so people can enter in the date information without having to use the picker.
7 changes: 7 additions & 0 deletions _data/changelogs/component-date-picker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ title: Date picker
type: component
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update the changelog dates before merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @amyleadem, do I just leave this here or do something else? Just let me know. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action needed from you now. Just flagging that this needs to be updated by whoever merges the PR (Usually Dan)

Copy link
Contributor

@annepetersen annepetersen Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For usability guidance that's primarily content, I should be able to merge also. Just did updated the changelog dates, and intend to merge once checks are completed successfully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could someone double-check on these failing/errored checks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyleadem or @cathybaptista, what should I know, and/or could you confirm whether or not I should merge despite these fails/errors?

summary: Added Date picker usability guidance.
summaryAdditional: Users should always be able to enter dates manually in Date picker.
cathybaptista marked this conversation as resolved.
Show resolved Hide resolved
affectsGuidance: true
githubPr: 2822
githubRepo: uswds-site
versionUswds: N.N.N
cathybaptista marked this conversation as resolved.
Show resolved Hide resolved
- date: 2024-03-13
summary: Added known issues section.
summaryAdditional:
Expand Down
7 changes: 7 additions & 0 deletions _data/changelogs/component-date-range-picker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ title: Date range picker
type: component
changelogURL:
items:
- date: NNNN-NN-NN
summary: Added Date range picker usability guidance.
summaryAdditional: Users should always be able to enter dates manually in Date range picker.
cathybaptista marked this conversation as resolved.
Show resolved Hide resolved
affectsGuidance: true
githubPr: 2822
githubRepo: uswds-site
versionUswds: N.N.N
cathybaptista marked this conversation as resolved.
Show resolved Hide resolved
- date: 2024-06-07
summary: Added known issues section.
summaryAdditional:
Expand Down