USWDS-Site - Guidance: Update usability guidance for Date Picker and Date Range Picker #2822
Conversation
Merge branch 'cb-changelog-2822' into cb-date-picker-and-date-range-guidance
There was a problem hiding this comment.
Looks good @cathybaptista. Added a couple of minor suggestions for the changelogs below.
| @@ -2,6 +2,13 @@ title: Date picker | |||
| type: component | |||
| changelogURL: | |||
| items: | |||
| - date: NNNN-NN-NN | |||
There was a problem hiding this comment.
Important
We should update the changelog dates before merge
There was a problem hiding this comment.
Hi, @amyleadem, do I just leave this here or do something else? Just let me know. :)
There was a problem hiding this comment.
No action needed from you now. Just flagging that this needs to be updated by whoever merges the PR (Usually Dan)
There was a problem hiding this comment.
For usability guidance that's primarily content, I should be able to merge also. Just did updated the changelog dates, and intend to merge once checks are completed successfully.
There was a problem hiding this comment.
Could someone double-check on these failing/errored checks?
There was a problem hiding this comment.
@amyleadem or @cathybaptista, what should I know, and/or could you confirm whether or not I should merge despite these fails/errors?
Merge remote-tracking branch 'origin' into cb-date-picker-and-date-range-guidance
updated changelog date
updating changelog date
Summary
Date Picker and Date Range Picker should always allow users to type the date manually if that is preferred.
Add text to the Usability Guidance sections for both components to let users know they should account for this preference.
Related issue
Closes #2294
Preview links
Preview links:
Date Picker
Date Range Picker
Changelog links:
Date Picker
Date Range Picker
Problem statement
Not all users want to use the calendar picker for dates. The Date Picker and the Date Range Picker components should be implemented so that users can enter dates manually if they choose to do so.
Solution
Update the guidance for Date Picker and Date Range Picker so that users are aware that these components should be implemented to allow users to type dates in manually.
Major changes
N/A, this is a change to the usability guidance.
Testing and review
Always allow a user to type in the date manually. Usability testing suggests some people prefer manually typing the date rather than using the calendar picker. Whenever possible, keep the keyboard active so people can enter in the date information without having to use the picker.
Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm run prettier:scssto format any Sass updates.npm testand confirm that all tests pass.