Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make htmllive target #124219

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix make htmllive target #124219

merged 1 commit into from
Sep 18, 2024
+1 −1

Conversation

zware
Copy link
Member

@zware zware commented Sep 18, 2024 •
edited
Loading

@zware
Allow make -C Doc htmllive to work without manual venv activation
6bc1152 
Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
@zware zware added docs Documentation in the Doc dir skip issue skip news labels Sep 18, 2024
colesbury
colesbury approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This fixes make htmllive for me.

@zware zware enabled auto-merge (squash) September 18, 2024 20:45
hugovk
hugovk approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zware zware added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 18, 2024
@zware zware merged commit 9a6e233 into python:main Sep 18, 2024
32 checks passed
@zware zware deleted the fix_doc_make_htmllive_target branch September 18, 2024 21:02
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@zware @miss-islington
Fix make htmllive target (pythonGH-124219)
effe2c2 
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2024

GH-124221 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@zware @miss-islington
Fix make htmllive target (pythonGH-124219)
183bc9a 
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2024

GH-124222 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 18, 2024
@hugovk hugovk mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zware @colesbury @hugovk @AA-Turner