Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: disabled two assertions while fuzzing #696

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/proto/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ where
// This is handled by resetting the frame then trying to read
// another frame.
Err(Error::Reset(id, reason, initiator)) => {
#[cfg(not(fuzzing))]
debug_assert_eq!(initiator, Initiator::Library);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nox do you recall why this is asserted? If it's Remote, should something else be done? This is getting trigger in fuzzing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done because from my understanding of the code back then this path should never be taken with Initiator::Remote, can you repro how it does happen?

tracing::trace!(?id, ?reason, "stream error");
self.streams.send_reset(id, reason);
Expand Down
1 change: 1 addition & 0 deletions src/proto/streams/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ impl Drop for Store {
fn drop(&mut self) {
use std::thread;

#[cfg(not(fuzzing))]
if !thread::panicking() {
debug_assert!(self.slab.is_empty());
}
Expand Down