Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: disabled two assertions while fuzzing #696

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f0rki
Copy link
Contributor

@f0rki f0rki commented Jun 20, 2023

No description provided.

@f0rki f0rki marked this pull request as draft June 20, 2023 06:38
@@ -448,6 +448,7 @@ where
// This is handled by resetting the frame then trying to read
// another frame.
Err(Error::Reset(id, reason, initiator)) => {
#[cfg(not(fuzzing))]
debug_assert_eq!(initiator, Initiator::Library);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nox do you recall why this is asserted? If it's Remote, should something else be done? This is getting trigger in fuzzing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done because from my understanding of the code back then this path should never be taken with Initiator::Remote, can you repro how it does happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants