Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename modules_exp to modules_for_bom to improve code and clarity #18603

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Rename modules_exp to modules_for_bom to improve code and clarity #18603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ function bom_pass {
log_callout "Checking bill of materials..."
# https://github.com/golang/go/commit/7c388cc89c76bc7167287fb488afcaf5a4aa12bf
# shellcheck disable=SC2207
modules=($(modules_exp))
modules=($(modules_for_bom))

# Internally license-bill-of-materials tends to modify go.sum
run cp go.sum go.sum.tmp || return 2
Expand Down
2 changes: 1 addition & 1 deletion scripts/test_lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ function modules() {
echo "${modules[@]}"
}

function modules_exp() {
function modules_for_bom() {
for m in $(modules); do
echo -n "${m}/... "
done
Expand Down
2 changes: 1 addition & 1 deletion scripts/updatebom.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function bom_fixlet {

local modules
# shellcheck disable=SC2207
modules=($(modules_exp))
modules=($(modules_for_bom))

if GOFLAGS=-mod=mod run_go_tool "github.com/appscodelabs/license-bill-of-materials" \
--override-file ./bill-of-materials.override.json \
Expand Down
Loading