Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules_exp to modules_for_bom to improve code and clarity #18603

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

lekaf974
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @lekaf974. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lekaf974 lekaf974 changed the title Remane modules_exp to modules_for_bom to improve code and clarity Rename modules_exp to modules_for_bom to improve code and clarity Sep 19, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Sep 19, 2024

/ok-to-test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (2ed418c) to head (d010b64).

Current head d010b64 differs from pull request most recent head 5b2faec

Please upload reports for the commit 5b2faec to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18603      +/-   ##
==========================================
- Coverage   68.83%   68.74%   -0.10%     
==========================================
  Files         420      420              
  Lines       35474    35519      +45     
==========================================
- Hits        24418    24416       -2     
- Misses       9636     9678      +42     
- Partials     1420     1425       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed418c...5b2faec. Read the comment docs.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your first contribution, Matthieu!
/cc @ahrtr

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for improving this @lekaf974

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement for clarity.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrybear327, ivanvc, jmhbnz, lekaf974, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit ce07474 into etcd-io:main Sep 19, 2024
45 checks passed
@ahrtr
Copy link
Member

ahrtr commented Sep 19, 2024

Thanks @lekaf974 for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Rename scripts' modules_exp to modules_for_bom
8 participants