Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EditorConfig #327

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Added EditorConfig #327

wants to merge 11 commits into from

Conversation

BorzdeG
Copy link
Contributor

@BorzdeG BorzdeG commented Aug 22, 2024

  1. Added EditorConfig
  2. Fixed the text formatting in the README
  3. Added revive linter
  4. Visual setting for IntelligJ IDE, no consequences on code validation
  5. Create issue Rename EnvVarIsNotSetError to VarIsNotSetError #328

1. Fixed the text formatting in the README
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (84c7739) to head (84a2f9b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          512       517    +5     
=========================================
+ Hits           512       517    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitignore Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@BorzdeG BorzdeG marked this pull request as draft August 22, 2024 11:22
@ccoVeille
Copy link

You are facing the line length nightmare

I did too with one of my project.

https://github.com/ccoVeille/golangci-lint-config-examples/blob/main/.editorconfig

Good luck, have fun 😅

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 22, 2024
@BorzdeG BorzdeG requested a review from ccoVeille August 22, 2024 12:33
@BorzdeG BorzdeG marked this pull request as ready for review August 22, 2024 12:33
.editorconfig Outdated Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
@BorzdeG BorzdeG requested a review from ccoVeille August 22, 2024 17:37
Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the previously discussed points that I'm adding back again

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@ccoVeille
Copy link

Thanks for baring with me, my feedbacks, and my iterative comments

LGTM 👍

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@BorzdeG BorzdeG requested a review from caarlos0 August 25, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants