Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editorconfig-checker-disable-next-line #180

Closed
andreineculau opened this issue Aug 25, 2021 · 5 comments · Fixed by #363
Closed

feat: editorconfig-checker-disable-next-line #180

andreineculau opened this issue Aug 25, 2021 · 5 comments · Fixed by #363

Comments

@andreineculau
Copy link

It may seen redundant to introduce such a feature at first, but here's GNU Make

You cannot use comments within variable references or function calls: any instance of # will be treated literally (rather than as the start of a comment) inside a variable reference or function call.

I bet there are other instances out on the wild, that cannot do with a inline comment to disable editorconfig-checker for that specific line.

@mstruebing
Copy link
Member

To whoever picks that up, this function needs to be adjusted: https://github.com/editorconfig-checker/editorconfig-checker/blob/main/pkg/validation/validation.go#L32

@ccoVeille
Copy link
Contributor

ccoVeille commented Aug 22, 2024

I'm interested by the feature, so I might try to work on this when I will have free time

Please confirm the need is still there and it's OK for me to work on it

@theoludwig
Copy link
Member

Feel free to work on it. 😄

@ccoVeille
Copy link
Contributor

OK, I will then.

@ccoVeille
Copy link
Contributor

I opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants