Kropotov - algo - hw04 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damik21
reviewed
Aug 3, 2021
| min_e = e if e < min_e else min_e | ||
| max_e = e if e > max_e else max_e | ||
| for idx, e in enumerate(a): | ||
| a[idx] = max_e if e == min_e else (min_e if e == max_e else e) |
There was a problem hiding this comment.
тут все же лучше проверять через отдельные условия. Иначе много раз будем перезаписывать одни и те же значения в массив, что не очень хорошо
damik21
reviewed
Aug 3, 2021
| start_ind = 0 | ||
| cur_simple = 0 | ||
| res = 0 | ||
| while start_ind < len(ma): |
There was a problem hiding this comment.
len(ma) у нас постоянное значение, поэтому лучше один раз вычислить его и хранить в переменной отдельной. так быстрее будет работать программа
damik21
reviewed
Aug 3, 2021
| simples.append(cur) | ||
| ind += 1 | ||
| cur += 2 | ||
| return simples[len(simples) - 1] |
damik21
reviewed
Aug 3, 2021
Comment on lines
+73
to
+74
| # Видимо не правильно реализовал второй алгоритм, хотя делал как понял. | ||
| # Нужно было определить верхню границу для i-го простого числа, нашел формулу 2*n*ln(n) |
There was a problem hiding this comment.
реализация правильная (в алгоритмическом смысле). Просто не самый эффективный код написан, ничего страшного в этом нету :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.