airbyte-ci: Ignore autogen files #45632
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This was referenced Sep 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
30b24fb
to
43cbd5c
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
cd8fbf0
to
00dee67
Compare
stephane-airbyte
approved these changes
Sep 18, 2024
|
Don’t forget to bump airbyte-ci version though. And add a changelog line.
|
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
43cbd5c
to
c36924e
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
00dee67
to
bba2b8e
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
c36924e
to
cd7a833
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
bba2b8e
to
847ae31
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
cd7a833
to
78dc640
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
847ae31
to
5933033
Compare
edgao
force-pushed
the
edgao/cdk_integration_tests
branch
from
78dc640
to
2d3af61
Compare
edgao
force-pushed
the
edgao/formatter_ignore_autogen_file
branch
from
5933033
to
586be8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45468 adds a new test that will autogenerate these
expected-spec.jsonfiles using Jackson's pretty printer (i.e. what we use in java connectors for json de/ser). Exclude them from the autoformatter.(also, submitted https://github.com/airbytehq/airbyte-internal-issues/issues/9863 b/c it would be nice to just use prettierignore)
tooling folks: I'm sure there's some changelog/version bumping stuff that I should do, can I get a pointer on how to do those things?