-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destinations cdk: implement snapshotting spec test #45468
base: edgao/formatter_ignore_autogen_file
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
678b120
to
82ab723
Compare
DestinationSyncMode.APPEND_DEDUP, | ||
) | ||
} | ||
//package io.airbyte.integrations.destination.e2e_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build is broken, commented this out just for testing purposes
79e7420
to
c8fa119
Compare
a708e68
to
7129f7c
Compare
c8fa119
to
1006072
Compare
7129f7c
to
60e7f4c
Compare
8ce08af
to
b1a901a
Compare
5d48b46
to
dfd289a
Compare
b1a901a
to
64b9b27
Compare
dfd289a
to
cc112ac
Compare
64b9b27
to
bb34611
Compare
cc112ac
to
cf46a03
Compare
f166b9f
to
d9b9550
Compare
cf46a03
to
f8e49cf
Compare
d9b9550
to
9ebc28b
Compare
f8e49cf
to
4cdec03
Compare
9ebc28b
to
e52c6bf
Compare
4cdec03
to
c2f4b23
Compare
e52c6bf
to
9964cfd
Compare
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-cdk/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/test/spec/SpecTest.kt
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/consts.py
Outdated
Show resolved
Hide resolved
c2f4b23
to
30b24fb
Compare
9964cfd
to
fc0bcd1
Compare
7fbe0ae
to
58f564a
Compare
cd8fbf0
to
00dee67
Compare
58f564a
to
66dc128
Compare
00dee67
to
bba2b8e
Compare
66dc128
to
9708552
Compare
bba2b8e
to
847ae31
Compare
9708552
to
23585e5
Compare
847ae31
to
5933033
Compare
23585e5
to
ea8314f
Compare
5933033
to
586be8b
Compare
ea8314f
to
7c7d04d
Compare
tl;dr add a test that:
spec
on the connectorexpected_spec.json
expected_spec.json
the original spec.json got deleted at some point in this stack? so I just created a new expected_spec.json - no strong opinion on where to put it, but I wanted it to be more obvious that it's not the "canonical" spec.
other things to note:
class E2eSpecTest: SpecTest()
. I'm pretty sure there's a way to make this work but haven't bothered looking into it yet, and I think this is good enough for now.prettier
, so I excluded the expected_spec.json files from airbyte-ci's format command.I already committed the updated spec, but there's still a few diffs against the original spec. Pasting them here, I think they're all intentional (e.g. changing type, tweaking wording, swapping
example
->examples
)example diff in expected_spec.json: