Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid value for property api_endpoint_overrides/storage #1683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid value for property api_endpoint_overrides/storage #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b7cb2
Fix invalid value for property api_endpoint_overrides/storage
carlosmerec Mar 23, 2023
e32aabe
Add coments and remove redudant tests
carlosmerec Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions gslib/tests/test_shim_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@ def test_gcs_json_endpoint_translation(self):
self.assertEqual(
env_vars, {
'CLOUDSDK_API_ENDPOINT_OVERRIDES_STORAGE':
'https://foo_host:1234/storage/v2',
'https://foo_host:1234/storage/v2/',
})

def test_gcs_json_endpoint_translation_with_missing_port(self):
Expand All @@ -1094,10 +1094,11 @@ def test_gcs_json_endpoint_translation_with_missing_port(self):
}):
flags, env_vars = self._fake_command._translate_boto_config()
self.assertEqual(flags, [])
self.assertEqual(env_vars, {
'CLOUDSDK_API_ENDPOINT_OVERRIDES_STORAGE':
'https://foo_host/storage/v2',
})
self.assertEqual(
env_vars, {
'CLOUDSDK_API_ENDPOINT_OVERRIDES_STORAGE':
'https://foo_host/storage/v2/',
})

def test_gcs_json_endpoint_translation_usees_default_version_v1(self):
with _mock_boto_config(
Expand All @@ -1107,10 +1108,12 @@ def test_gcs_json_endpoint_translation_usees_default_version_v1(self):
}}):
flags, env_vars = self._fake_command._translate_boto_config()
self.assertEqual(flags, [])
# Implicitly testing that the translation must start with
# https:// and end with a trailing forward slash.
self.assertEqual(
env_vars, {
'CLOUDSDK_API_ENDPOINT_OVERRIDES_STORAGE':
'https://foo_host:1234/storage/v1'
'https://foo_host:1234/storage/v1/'
})

def test_s3_endpoint_translation(self):
Expand Down
6 changes: 4 additions & 2 deletions gslib/utils/shim_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ def _get_gcs_json_endpoint_from_boto_config(config):
gs_json_port = config.get('Credentials', 'gs_json_port')
port = ':' + gs_json_port if gs_json_port else ''
json_api_version = config.get('Credentials', 'json_api_version', 'v1')
return 'https://{}{}/storage/{}'.format(gs_json_host, port,
json_api_version)
# Note that the json endpoint must start with https://
# and end with a trailing forward slash.
return 'https://{}{}/storage/{}/'.format(gs_json_host, port,
json_api_version)
return None


Expand Down