Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid value for property api_endpoint_overrides/storage #1683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid value for property api_endpoint_overrides/storage #1683

wants to merge 2 commits into from
+13 −8

Conversation

carlosmerec
Copy link
Contributor

@carlosmerec carlosmerec commented Mar 23, 2023 •
edited
Loading

When the shim is used the following error is thrown by gcloud:

Invalid value for property [api_endpoint_overrides/storage]: The endpoint_overrides property must be an absolute URI beginning with http:// or https:// and ending with a trailing '/'. [https://storage.googleapis.com/storage/v1] is not a valid endpoint override.

This is in case the user passes the gs_json_host config variable.

dilipped
dilipped reviewed Mar 23, 2023
View reviewed changes
gslib/tests/test_shim_util.py Outdated Show resolved Hide resolved
gslib/tests/test_shim_util.py Outdated Show resolved Hide resolved
@dilipped dilipped added the kokoro:run kokoro:run label Mar 24, 2023
@gsutil-team-kokoro gsutil-team-kokoro removed kokoro:run kokoro:run labels Mar 24, 2023
@carlosmerec
Copy link
Contributor Author

carlosmerec commented Mar 24, 2023 •
edited
Loading

Kokoro tests: the linux ones fail due to BUILD FAILED and the mac os one is because of a test failure but it seems it is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilipped dilipped dilipped left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosmerec @dilipped @gsutil-team-kokoro