Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 1password as backend (#404) #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrea11
Copy link

@andrea11 andrea11 commented Aug 20, 2023

This adds 1Password support!

@andrea11
Copy link
Author

99designs/aws-vault#404

@andrea11
Copy link
Author

andrea11 commented Aug 20, 2023

Hi @mtibben @lwc @creativej @spearki,
could you please review this when you have time?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests pass locally, however, I am not sure how to make it works in the ci/cd. I am afraid that a 1password account is required

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One option, if the team is willing, is to sign up for a free open source team account and create a test user. https://github.com/1Password/1password-teams-open-source

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone from AgileBits/1Password can help here? Jack (@plttn ) I hope you don't mind me asking what do you think would be the best way to go about helping the aws-vault team get their 1Password integration unit tests to pass in CI? Do you know the best person to contact?

Copy link

@plttn plttn Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! As mentioned, your best bet would be to sign up for our 1Password for Open Source program.

Once you've been approved, you could use a 1Password Service Account in that team account to do your unit tests in Github Actions. If the environment variable OP_SERVICE_ACCOUNT_TOKEN is set in GitHub Actions, 1Password CLI will use that credential when performing actions, which should allow your CI/CD to pass.

Cheers!

@andrea11
Copy link
Author

Any news on this? @lox maybe you can have a look?

@chrisgilmerproj
Copy link

Thanks for writing this MR @andrea11 . 1password support would be really great on systems that only have the CLI. I'm currently using pass as the backend but it would be wonderful to switch to 1password where I store everything else. Any chance we could get this merged in, even if its hidden behind some kind of experimental flag?

@AndyTitu
Copy link

AndyTitu commented Jul 4, 2024

Also, 1Password now has a Go SDK https://github.com/1Password/onepassword-sdk-go that could make building this easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants