Completion: Add make variables with values #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far only variable names were added. However Makefiles and make would also return possible values which are not completed so far. The values are stored and overwritten in the map without using them anywhere. So instead it currently makes more sense to complete the whole variable name-value combination instead of only the name.
|
This contribution should probably be discussed on the mailing list, since it significantly changes completion behavior. Very few committers monitor this repository mirror, and little to no discussion happens here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only variable names were added. However Makefiles and make would also return possible values which are not completed so far. The values are stored and overwritten in the map without using them anywhere. So instead it currently makes more sense to complete the whole variable name-value combination instead of only the name.
I'm unsure about this change because I have not completely understood zsh's completion system yet. However it works for me (version 5.8 and call-command set true) as I want it to be. It's similar to bash's behavior with that.