Add topologySpreadConstraints configuration to pod spec. #2530
Conversation
laiminhtrung1997
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
2 times, most recently
from
b948c94
to
44fcb1f
Compare
|
We need that feature too. |
| @@ -465,6 +465,11 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa | |||
| needsRollUpdate = true | |||
| reasons = append(reasons, "new statefulset's pod affinity does not match the current one") | |||
| } | |||
| if !reflect.DeepEqual(c.Statefulset.Spec.Template.Spec.TopologySpreadConstraints, statefulSet.Spec.Template.Spec.TopologySpreadConstraints) { | |||
| needsReplace = true | |||
| needsRollUpdate = true | |||
There was a problem hiding this comment.
does this really need to trigger a rolling update of pods executed by operator? Will not K8s take care of it then once the statefulset is replaced?
There was a problem hiding this comment.
I see, but is this wrong too?
https://github.com/zalando/postgres-operator/blob/master/pkg/cluster/cluster.go#L472
There was a problem hiding this comment.
hm good point. Maybe we can leave as is for now. With rolling update we make sure pods immediately adhere the new constraints.
|
Can you also write an e2e test that tests that the constraints work as expected, please? |
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
8 times, most recently
from
530f847
to
18023cb
Compare
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
8 times, most recently
from
a21c24d
to
1b00777
Compare
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
15 times, most recently
from
434c6c5
to
ee2b43d
Compare
|
Dear @FxKu |
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
from
ee2b43d
to
24b9f65
Compare
|
Dear @FxKu |
|
@laiminhtrung1997 thanks a lot for the update. I think, in this state you can be sure we will merge it for the next release. We have to focus on the new status feature first but I will get back to you in September. |
Dear all,
I think we should configure topologySpreadConstraints to pod spec so these pods can spread zones for high availability.
Could someone review it, please? Thank you very much.
Best regards.