add support for overlapping marks #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamDuvall
reviewed
Sep 1, 2021
| /** | ||
| * @param {Y.XmlText} ytext | ||
| * @param {Array<any>} ptexts | ||
| */ | ||
| const equalYTextPText = (ytext, ptexts) => { | ||
| const delta = ytext.toDelta() | ||
| return delta.length === ptexts.length && delta.every((d, i) => d.insert === /** @type {any} */ (ptexts[i]).text && object.keys(d.attributes || {}).length === ptexts[i].marks.length && ptexts[i].marks.every(mark => equalAttrs(d.attributes[mark.type.name] || {}, mark.attrs))) | ||
| return delta.length === ptexts.length && delta.every((d, i) => d.insert === /** @type {any} */ (ptexts[i]).text && countYTextMarks(d.attributes || {}) === ptexts[i].marks.length && ptexts[i].marks.every(mark => containsEqualMark(d.attributes[mark.type.name] || {}, mark.attrs))) |
There was a problem hiding this comment.
Thanks for the PR for handling multiple marks!
I was pulling this PR into my project and ran into an issue with containsEqualMark. It looks like you're calling containsEqualMark with yattrs, pattrs instead of pattrs, yattrs.
IdrissMahjoubi
pushed a commit
to Collaborne/y-prosemirror
that referenced
this pull request
Jun 16, 2022
This is inspired from this PL: yjs#52
|
Since y-prosemirror/src/plugins/sync-plugin.js Line 961 in 7a3afbc |
|
Hey @dmonad, I know it's an old PR, but could you please let us know if this is the right direction to take for supporting overlapping ProseMirror marks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #34 - while remaining backwards compatible.
There are still two TODO items open open:
yjs, but want to make sure the solution I'm implementing here is a right approach.