Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update got to v11 #794

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Update got to v11 #794

merged 3 commits into from
Nov 6, 2023

Conversation

strmer15
Copy link
Contributor

@strmer15 strmer15 commented Nov 3, 2023

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:
    Updating a dependency that has security vulnerabilities reported, due to out-of-date subdependencies.

What changes did you make?

I updated the got library to v11, which is the latest that can be used without switching to ESM-only. The only thing that it's currently being used for is to pull a blacklist from the web when installing a generator. The only change that was relevant was removing the {json: true} config in favor of the .json() function to return a Promise with a JSON body.

This package currently uses got v8, here are the releases between then and v11:

https://github.com/sindresorhus/got/releases/tag/v11.0.0
https://github.com/sindresorhus/got/releases/tag/v10.0.0
https://github.com/sindresorhus/got/releases/tag/v9.0.0

Is there anything you'd like reviewers to focus on?

The http://yeoman.io/blacklist.json website doesn't seem to exist - when I go to it in my browser I get a 404. Is this functionality even working currently, or should there be a different blacklist URL?

@strmer15
Copy link
Contributor Author

strmer15 commented Nov 3, 2023

This should fix #780

@strmer15
Copy link
Contributor Author

strmer15 commented Nov 6, 2023

@mshima Would you be able to review this?

@mshima
Copy link
Member

mshima commented Nov 6, 2023

@strmer15 please increase tests timeout for tests to pass.

@strmer15
Copy link
Contributor Author

strmer15 commented Nov 6, 2023

@strmer15 please increase tests timeout for tests to pass.

Ok, will do - thanks!

@strmer15
Copy link
Contributor Author

strmer15 commented Nov 6, 2023

@mshima Updated it just now and everything is passing 👍

@mshima mshima merged commit ca168e4 into yeoman:main Nov 6, 2023
6 checks passed
@strmer15 strmer15 deleted the update_got branch November 6, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants