Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure minimal Node.js version #256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Mar 23, 2023

Main changes

  • Added Nodejs 16 as the minimum version and regenerated pkg lock file (422579b)
  • Added support for NVM

Changelog

- Updated Engine version to 14 in pkg
- Regenerated package-lock
@UlisesGascon UlisesGascon added this to the 6.0.0 milestone Mar 23, 2023
@UlisesGascon UlisesGascon marked this pull request as ready for review March 23, 2023 18:57
package-lock.json Outdated Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the package-lock.json file still removes all the v2 metadata, can you please remove these changes? ideally there's no change to that file (maybe only to update the small section that replicates the package.json engines data if that's the case)

@ngogiaphat
Copy link

v2 metadata what else ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants