Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade YASA to work with Solr 9x, with a 0.6.0 release #95

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chatman
Copy link
Contributor

@chatman chatman commented Apr 20, 2023

  • Upgraded to Solr 9x
  • New version 0.6.0
  • Upgraded java version to 11
  • Removed the yasa-ui/package-lock.json from tracked files

Tested with Solr 9.0, works fine.

After merging this, next steps to release would be:

  • Releasing the 0.6.0 artifacts on GitHub
  • Signing the jar using private key (only Ke can do this?)
  • Updating the repo/repository.json file to add the entry for 0.6.0 with the signature

Steps to sign:

{{openssl dgst -sha1 -sign <path-to-privatekey.pem> | openssl enc -base64}}
(remove the newline, concatenate the first and second line to form a single string without spaces)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience this file should be checked into codebase, otherwise in a fresh new environment the installed packages' versions might be different from the ones that we tested, and it might break the build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I don't see a reason to remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed... package-lock.json should be shared...

@chatman
Copy link
Contributor Author

chatman commented Apr 21, 2023 via email

@kezhenxu94 kezhenxu94 force-pushed the master branch 3 times, most recently from 663a13b to 085918c Compare April 21, 2023 04:18
@kezhenxu94
Copy link
Member

kezhenxu94 commented Apr 21, 2023

  • Signing the jar using private key (only Ke can do this?)

Hey @chatman , I've created a workflow to automatically release a version on new tags (yasa-org/developer members can create tags), if you need a new version, feel free to push a tag and use the new release, note the tag name should be v1.2.3 format, v\d+\.\d+\.\d+

https://github.com/yasa-org/yasa/actions/workflows/Release.yaml

@MarcusSorealheis
Copy link
Contributor

We should test with version 17 as well.

@chatman
Copy link
Contributor Author

chatman commented Apr 24, 2023

This works with Solr 9.0 and 9.1. It is broken with 9.2, due to https://issues.apache.org/jira/browse/SOLR-16769.
Hopefully, this will be fixed in an upcoming 9.2.1.

This should stay and not be ignored...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! I literally got bit by this in writing a nicer test_packages.bats test!

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the package lock thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants