Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (partially) Svelte E2E test #6428

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

clemyan
Copy link
Member

@clemyan clemyan commented Aug 1, 2024

What's the problem this PR addresses?

The SvelteKit E2E test has been failing

How did you fix it?

  • create-svelte discontinued the next dist-tag, use latest instead
  • I don't know how it was but yes cannot defeat create-svelte interactivity now, so I just use its node API instead
  • Also added a TypeScript test

The test should still be failing due to sveltejs/kit#11433 (comment), but at least it is an actual failure of the E2E test, not of our setup. 🤷

Closes #6345

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@clemyan clemyan requested a review from arcanis as a code owner August 1, 2024 13:34
@merceyz merceyz mentioned this pull request Aug 1, 2024
3 tasks
@merceyz merceyz enabled auto-merge August 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants