WIP: Enable different entity managers for multiple log entities #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronisaha
requested changes
Nov 28, 2019
| @@ -32,9 +31,9 @@ class DoctrineObjectEventResolver implements EventResolverInterface | |||
| protected $identity = ['', '']; | |||
|
|
|||
| /** | |||
| * @var ManagerRegistry | |||
| * @var \Doctrine\ORM\EntityManager | |||
There was a problem hiding this comment.
As we also support ODM, we don't want direct dependency with ORM. You can see we remove the dependency in a earlier commit
| @@ -30,7 +30,8 @@ | |||
| "phpunit/phpunit": "^5.0 || ^6.0", | |||
| "friendsofsymfony/user-bundle": "^2.0", | |||
| "php-coveralls/php-coveralls": "^2.1", | |||
| "doctrine/common": ">=2.2 <3.0" | |||
| "doctrine/common": ">=2.2 <3.0", | |||
| "doctrine/orm": "^2.2" | |||
There was a problem hiding this comment.
No dependency should be with ORM
| /** | ||
| * @param AuditLog $event | ||
| */ | ||
| protected function saveLog(AuditLog $event) | ||
| { | ||
| $this->getManager()->persist($event); | ||
| $this->getManager()->flush($event); | ||
| $manager = $this->doctrine->getManagerForClass($event); |
There was a problem hiding this comment.
getManagerForClass expect class name not an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP