Clarify usage of secrets in docs #4099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
pat-s
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Thanks for the follow-up to my previous comment.
Besides the inline comments (which should be ported to the 2.7 docs if accepted), I am still missing a section which explains in detail:
- why
environment:has been removed from all plugins (and starting with which version) - how using secrets via a plugin setting option is different/more secure
|
|
||
| ### Use secrets in plugins via settings | ||
|
|
||
| The `from_secret` syntax also work for settings in any hierarchy. |
There was a problem hiding this comment.
Here we should add more information on why secrets cannot be used via environment: in plugins.
Co-authored-by: Patrick Schratz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #4096 (comment)