Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clever Cloud deploy guide #9030

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Clever Cloud deploy guide #9030

wants to merge 22 commits into from

Conversation

juliamrch
Copy link

@juliamrch juliamrch commented Aug 7, 2024

Description (required)

This PR includes:

  • A new deploy guide in English for deploying on Clever Cloud, on static or SSR mode
  • The Clever Cloud logo
  • A link on /src/guides/deploy that directs to the guide

Preview pages

Related issues & labels (optional)

  • Closes #
  • Suggested label:

We love Astro at Clever Cloud <3 and we have ran some tests to try its features. Hope this PR is clear enough, feel free to ask for clarifications or to point out errors in this doc if needed.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit caaba37
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66eaa5641e6e6e00082c8b1e
😎 Deploy Preview https://deploy-preview-9030--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@juliamrch juliamrch changed the title Cc doc Clever Cloud deploy guide Aug 7, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/deploy/clever-cloud.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Aug 7, 2024
@sarah11918
Copy link
Member

Thanks for this submission, @juliamrch ! I'll wait until it's out of draft before having anyone look at it for a review!

In the mean time, this PR appears to commit some changes to other files (VS Code settings, package.json). Can you make sure these don't end up in the final PR? Thanks! 🙌

@juliamrch
Copy link
Author

Thanks for the feedback @sarah11918 I will make sure it doesn't include non-relevant files and mark it as ready next.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 7, 2024
@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 7, 2024
@juliamrch juliamrch marked this pull request as ready for review August 7, 2024 14:42
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juliamrch. Thanks for the PR!

I've run through the guide for the first time, and provided some initial feedback. There were some things blocking me from completing the deployment, but I managed to eventually, and added some feedback on using different package managers, using preview over dev, etc.
Once these issues are resolved, I'll run through a second time to check everything works, and then review the wording.

If you need help with anything, please let me know!

src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
Comment on lines 110 to 121
<CardGrid>
<LinkCard
title="Node.js documentation"
description="Clever Cloud documentation on Node.js applications."
href="https://developers.clever-cloud.com/doc/applications/javascript/nodejs/"
/>
<LinkCard
title="Static documentation"
description="Clever Cloud documentation on Static applications."
href="https://developers.clever-cloud.com/doc/applications/static/"
/>
</CardGrid>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<CardGrid>
<LinkCard
title="Node.js documentation"
description="Clever Cloud documentation on Node.js applications."
href="https://developers.clever-cloud.com/doc/applications/javascript/nodejs/"
/>
<LinkCard
title="Static documentation"
description="Clever Cloud documentation on Static applications."
href="https://developers.clever-cloud.com/doc/applications/static/"
/>
</CardGrid>
## Official Resources
- [Node.js documentation](https://developers.clever-cloud.com/doc/applications/javascript/nodejs/)
- [Static app documentation](https://developers.clever-cloud.com/doc/applications/static/)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove the cards? They're so pretty 🥲

Comment on lines 7 to 10
import ReadMore from '~/components/ReadMore.astro';
import { Steps } from '@astrojs/starlight/components';
import { CardGrid, LinkCard } from '@astrojs/starlight/components';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import ReadMore from '~/components/ReadMore.astro';
import { Steps } from '@astrojs/starlight/components';
import { CardGrid, LinkCard } from '@astrojs/starlight/components';
import { Steps } from '@astrojs/starlight/components';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@casungo casungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor things that could be improved in this PR :)

package.json Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/clever-cloud.mdx Outdated Show resolved Hide resolved
juliamrch and others added 2 commits September 18, 2024 11:56
juliamrch and others added 5 commits September 18, 2024 11:58
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
Co-authored-by: casungo <[email protected]>
@juliamrch
Copy link
Author

I found some minor things that could be improved in this PR :)

Thanks @casungo syntax senpaï

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants