Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative_url in language switcher #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

auxonic
Copy link

@auxonic auxonic commented Mar 27, 2023

I've been working on a little example site using the gcweb jekyll theme for internal use and noticed that the alt lang url doesn't use the relative_url filter like the breadcrumbs do.

That means for sites using subdirectories like most github pages the alt lag url omits the baseurl. For sites running at the root there's no impact from this bug.

I added a note in the default _config.yml file about the value you might set baseurl to as well.

Possible risk: Impact on a site is minimal but for content that has already been created where the baseurl has been manually addded to the altlang url then the content would have to be updated.

@delisma delisma added bug Something isn't working good first issue Good for newcomers workinprogess Label for PR that should not be merge yet labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers workinprogess Label for PR that should not be merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants