Process killer feature #838
Conversation
There was a problem hiding this comment.
I am not sure how useful this would be for a user given they might not know on which port the driver was run. Can't we just improve how we kill the process and try another attempt if we we detect that the port is still occupied?
I think it would be a better approach to actually guarantee to free up the port.
@christian-bromann Yes agreed it has sense, not necessary kill it if port is free already, and we can take port number from seleniumStatusUrl.port, not necessary set it directly, i've added changes |
| @@ -111,6 +111,8 @@ By default all drivers are loaded, you only control and change the versions or a | |||
|
|
|||
| `opts.requestOpts` can be any valid [`got` options object](https://www.npmjs.com/package/got#proxies). You can use this for example to set a timeout. | |||
|
|
|||
| `opts.processKiller` set for that truthy value, for killing selenium server port. | |||
There was a problem hiding this comment.
| `opts.processKiller` set for that truthy value, for killing selenium server port. | |
| `opts.processKiller` set to a truthy value, for killing selenium server port. |
| @@ -121,6 +123,8 @@ If you're getting this error, it means that you didn't shut down the server succ | |||
| pkill -f selenium-standalone | |||
| ``` | |||
|
|
|||
| or use truthy `opts.processKiller` in config | |||
There was a problem hiding this comment.
| or use truthy `opts.processKiller` in config | |
| or use `opts.processKiller` in config |
| @@ -49,6 +49,9 @@ selenium-standalone start --singleDriverStart=chrome | |||
| selenium-standalone install --config=/path/to/config.json | |||
| selenium-standalone start --config=./config/seleniumConfig.js | |||
|
|
|||
| # killing process before starting | |||
| selenium-standalone start --processKiller=true | |||
There was a problem hiding this comment.
A user would ask why they would need to set this given it feels like the expected behavior is that the selenium server or driver shuts down completely when the process is triggered to get shutdown.
Yes it could be behavior by default, i've asked about that in first message of the pr. But in the case i'm convinced we should have possibility to switch off it. Because there could be some rare cases when process on port :4444 related to java in list of processes and we're killing java process too. It's necessary when fkill can't perform killing by port and then we'are looking for all processes related to selenium port and killing it. For the most cases it should work but we don't know what else has been connected to java and maybe user wouldn't like to have the behavior. |
@christian-bromann Generally it's a good feature when we can check and kill selenium processes by port :4444 and drivers names before starting.
Tests added
Bug is here #599
And I'm not convinced but maybe it have sense to be switched on in config by default. Currently it's not switched on.