Iaconos rgbled #12
Open
Iaconos rgbled #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit acc27bf.
Tried original wallysami rgb-led version and found the use of alpha to caused a lack of brightness in LED rendering and also resulted in less realistic blending of red-green-blue values. This version addresses both of those issues. It uses realistic brightness and realistic colors.
Tried original wallysami rgb-led version and found the use of alpha to caused a lack of brightness in LED rendering and also resulted in less realistic blending of red-green-blue values. This version addresses both of those issues. It uses realistic brightness and realistic colors. This commit includes slight correction to previous commit.
image file necessary for improved rgbled
|
I tried something like that at first, but the LED gets significantly darker with a initial value:
In my real life tests, the LED gets really bright for small values and doesn't vary that much from there. This is why I tried a color shift and a non-linear scale. rgba_components = [value ** 0.3 * 0.6 + 0.4 for value in self._current_state]and this was the result
This is not an easy thing to represent in a computer screen. The color combination in some real LEDs doesn't blend very well in many cases. But there are definitely things to improve in my solution (e.g. blue light should be more greenish, the color mixture is not quite right for all cases, etc). I'll think about it. |
|
Yes, I thought maybe that was why you did the shift.
We maybe want to see about combining your idea of the shift with my more realistic colors and brightness
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried original wallysami rgb-led version and found the use of alpha to caused a lack of brightness in LED rendering and also resulted in less realistic blending of red-green-blue values.
This version addresses both of those issues. It uses realistic brightness and realistic colors.