Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): handle hotkeys by event.code #1993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rudnovd
Copy link

@rudnovd rudnovd commented Nov 26, 2022

Description

In the current version hotkeys that use English letters (alt+f, alt+s, alt+d, ctrl+alt+r) are handled by event.key, which makes it impossible to use them in other language keyboard layouts.
Handling keys with event.code fixes this problem.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum
Copy link
Member

Akryum commented Jan 20, 2023

Problem with code is that it ignores keyboard layouts and try to force a QWERTY layout on the user keyboard :|

@rudnovd
Copy link
Author

rudnovd commented Jan 22, 2023

@Akryum maybe you can suggest ways of solving this problem?

@edikdeisling edikdeisling mentioned this pull request Oct 14, 2023
8 tasks
Copy link

@marcosdissotti marcosdissotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants