Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): attach current instance to render slot #168

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Mar 26, 2024

related: #4, #53

The APIs such as renderEffect and withDirectives rely on currentInstance to function properly, but after passing slots to child components, the instance where the block function runs will change.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 3aba5c9
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/661113376bed780008ff168a
😎 Deploy Preview https://deploy-preview-168--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 3aba5c9
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/661113379b41770008cbd9c4
😎 Deploy Preview https://deploy-preview-168--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 26, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 49 kB 16.7 kB 15.1 kB
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 42.2 kB (+130 B) 15.7 kB (+39 B) 14.4 kB (+40 B)
vue-vapor.global.prod.js 88.7 kB (+130 B) 30.9 kB (+41 B) 28 kB (+14 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 42.4 kB (+130 B) 15.7 kB (+36 B) 14.4 kB (+41 B)
overall 68.5 kB 26.1 kB 23.6 kB

@LittleSound LittleSound marked this pull request as draft March 28, 2024 09:26
@LittleSound LittleSound force-pushed the feat/runtime-vapor-slots-with-ctx branch from dd6a69b to 2e39f3e Compare April 6, 2024 09:03
@LittleSound LittleSound marked this pull request as ready for review April 6, 2024 09:21
@sxzz sxzz merged commit 9a33d79 into main Apr 6, 2024
11 checks passed
@sxzz sxzz changed the title feat(runtime-vapor): the current instance should be kept in the slot feat(runtime-vapor): attach current instance to render slot Apr 6, 2024
@sxzz sxzz deleted the feat/runtime-vapor-slots-with-ctx branch April 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants