Fix issue 293 by handling default value with type ATV_BITVECTOR #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouse07410
reviewed
Sep 30, 2018
libasn1compiler/asn1c_C.c
Outdated
| if(expr->marker.default_value == NULL | ||
| || expr->marker.default_value->type != ATV_STRING) | ||
| if(expr->marker.default_value) { | ||
| if(!(etype & ASN_STRING_KM_MASK) && |
There was a problem hiding this comment.
Are you sure it should be && and not ||? The logic seems to need "if the type is not a STRING derivative, or default not provided, or (default is neither BIT STRING nor OCTET STRING), then break". Correct?
There was a problem hiding this comment.
BIT STRING -> etype : ASN_BASIC_BIT_STRING , default_value_type : ATV_BITVECTOR
OCTET STRING -> etype : ASN_BASIC_OCTET_STRING, default_value_type : ATV_BITVECTOR
IA5String -> etype : ASN_STRING_IA5String, default_value_type : ATV_STRING
However, ASN_BASIC_BIT_STRING and ASN_BASIC_OCTET_STRING do not have bits set with ASN_STRING_KM_MASK.
I admit that this is a little obscure but I tried to be safe for possible combinations I could figure out.
To simplify it, perhaps we could just check default_value->type against ATV_STRING and ATV_BITVECTOR.
There was a problem hiding this comment.
I see. Would you say that ATV_STRING and ATV_BITSTRING cover all the possibilities we want to include here?
1. Modify asn1p_y.c and asn1p_y.y to fix an error that function _convert_bitstring2binary() always return NULL. 2. Add handling for default value with type ATV_BITVECTOR in function try_inline_default().
brchiu
force-pushed
the
fix_issue_293_incorrest_OER_encoding_of_default_BIT_STRING_value
branch
from
da56723
to
83c3166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify asn1p_y.c and asn1p_y.y to fix an error that
function _convert_bitstring2binary() always return NULL.
Add handling for default value with type ATV_BITVECTOR in
function try_inline_default().
ref comments in #293