Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the metadata from setup.cfg into PEP 621-compliant pyproject.toml #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Jun 9, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@viraptor
Copy link
Owner

Is there are reason to do this now? What's the minimum python to deal with this?

@KOLANICH
Copy link
Contributor Author

As you see, there are 2 commits. It is intentional, these commits should NOT be collapsed into a single one.

  1. One migrates the metadata into setup.cfg, which is in fact available in setuptools from Dec 2016, but we set the requirements to a later version of setuptools, because the one from 2016 doesn't allow to get rid of setup.py entirely, but 43.0.0, which python_requires = >=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.* does.
  2. Another one migrates the metadata into pyproject.toml, which is a standard (PEP 621) way to store the metadata now, which is compatible to setuptools, flit and maturin PEP 517 build frontends. poetry is on the way. It requires setuptools>=61.2.0, which python_requires = >=3.7. Obviously, Windows XP users (which maximum CPythkn version is 3.4) are thrown into a dumpster with building, but I think we can try to backport this setuptools to 3.4, usually python version is raised because of bullshit bells-and-whistles features like f-strings (and I guess we can fully automatically rewrite them into format calls) and cool features like type annotations (but there is a 3.4-compatible way, called type comments, with built-in support in ast module). Anyway, this only restricts building, the wheels are compatible to the python version stated in them, the most of users use prebuilt wheels from pypi, and even if they need the latest version from git, noone disallows them to fetch the wheel, unpack it, replace the source files in it and pack it back.

@viraptor
Copy link
Owner

Cool, thanks. Since this isn't urgent, I think I'll wait until April 2023, when ubuntu LTS drops python 3.6.

@KOLANICH
Copy link
Contributor Author

The first commit can be merged right now.

@thesamesam
Copy link

Cool, thanks. Since this isn't urgent, I think I'll wait until April 2023, when ubuntu LTS drops python 3.6.

Would this be okay to merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants