Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpdoc in test and show an error #10929

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Draft

Fix phpdoc in test and show an error #10929

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet VincentLanglet mentioned this pull request Apr 29, 2024
Draft
@VincentLanglet
Copy link
Contributor Author

Hi @orklah @weirdan.

As shown by this PR the current test is wrong
@template TRequestedInstance extends InstanceType is not a valid syntax and fixing it to
@template TRequestedInstance of InstanceType is failing the test.

I didn't find a way to solve this test, dunno what it's testing (and certainly not a good thing since it's wrong)
Is it ok to remove it ?

This is blocking my PR #10927

Thanks.

@VincentLanglet
Copy link
Contributor Author

This test was introduced by #10191

I assume the bug you tried to fix is not fully fixed. Any idea how to fix it @boesing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VincentLanglet