Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new oEmbed parameters #957

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

christriants
Copy link
Contributor

@christriants christriants commented Dec 14, 2023

This PR adds support oEmbed support for the following player embed settings:

  • airplay - enable / disable AirPlay in the player
  • audio_tracks - enable / disable alternate audio tracks in the player. This has no effect if the video does not have alternate audio.
  • cc - enable / disable closed captions / subtitles in the player. This has no effect if the video does not have captions.
  • chapters - enable / disable chapters in the player. This has no effect if the video does not have chapters set.
  • chromecast - enable / disable Chromecast in the player
  • fullscreen - show / hide the fullscreen button in the player
  • play_button_position - position the play button within the player. Options are auto | bottom | center
  • progress_bar - show / hide the progress bar in the player
  • quality_selector - show / hide the quality selector in the player
  • transcript - enable / disable the transcript in the player. This has no effect if the video does not have a transcript.
  • vimeo_logo - show / hide the Vimeo logo in the player
  • volume - show / hide volume controls in the player

We also remove the esm package.

@christriants christriants force-pushed the add-oembed-support-for-controls-settings branch 2 times, most recently from 9a0b846 to 850d387 Compare December 18, 2023 19:19
@christriants christriants marked this pull request as draft December 18, 2023 19:28
@christriants christriants force-pushed the add-oembed-support-for-controls-settings branch from 850d387 to e51f540 Compare December 18, 2023 19:53
@christriants christriants force-pushed the add-oembed-support-for-controls-settings branch from 379cb0c to f2f64b1 Compare December 20, 2023 15:32
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af0a78c) 72.00% compared to head (f2f64b1) 72.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #957   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files           7        7           
  Lines         575      575           
=======================================
  Hits          414      414           
  Misses        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christriants christriants marked this pull request as ready for review December 20, 2023 17:51
@christriants christriants self-assigned this Dec 20, 2023
@christriants christriants merged commit f4773b4 into master Jan 2, 2024
3 checks passed
@christriants christriants deleted the add-oembed-support-for-controls-settings branch January 2, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants