keebio/sinc: add vial support for rev2 #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Beckers <[email protected]>
|
the change to keyboard.json will cause conflicts with qmk, it needs to be limited to the vial folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, looks like this was attempted before in #404, though unsuccessfully. A few things have changed in QMK, and the official rev4 vial keymap landing was a huge help in getting this set up.
As such, this is mostly a copy of rev4, though with none of the rp2040 stuff since the rev2 is an atmega that has most of the boilerplate well taken care of by qmk itself. I suspect this can be copy-pasted verbatim to the rev1 board, since afaik it's fairly similar.
The changes made to
keyboard.jsonare mostly to switch from rgblight/backlight to rgb_matrix, mainly to support sleep on idle and suspend. While making this PR, I just realized the backlight feature I removed must be for the monochrome per-key lighting but I haven't seen anyone actually use that in the past decade or so. Removing it yielded a nice space savings, but I can try to reenable it if necessary. While I had it enabled during development, I didn't see a way to configure it in the Vial UI, though, so I'm not sure how it's supposed to be used or how it works.The rest is taken mostly unchanged from the rev4 keymap, with some rgb effects disabled since they don't act on underglow LEDs.
Let me know what you think!