Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 'errno' and use copied value in the if check of retry in cluster migrate commands socket_err block. #1042

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented Sep 17, 2024

errno is global variable and shared with system calls, so there is chance it may be overwritten during io free or close socket in migrate command code. It would be better it is copied before the free or closesocket and use copied value to check for retry in socket_err block. So added new variable to take copy and used the copy variable for the check. Thanks!

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (f89ff31) to head (9be7875).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1042      +/-   ##
============================================
+ Coverage     70.58%   70.59%   +0.01%     
============================================
  Files           114      114              
  Lines         61670    61672       +2     
============================================
+ Hits          43530    43540      +10     
+ Misses        18140    18132       -8     
Files with missing lines Coverage Δ
src/cluster.c 88.13% <100.00%> (-0.26%) ⬇️

... and 8 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit ba71c7e into valkey-io:unstable Sep 18, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants