chore: More detailed logging for ignored handling #20007
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make log more detailed for ignored invocation handle.
tltv
reviewed
Sep 20, 2024
| @@ -723,4 +724,14 @@ public static Router getRouter(HasElement component) { | |||
| return router; | |||
| } | |||
|
|
|||
| public static Optional<Component> getRouteComponent(Component component) { | |||
There was a problem hiding this comment.
JavaDoc missing from a public API.
There was a problem hiding this comment.
Maybe not for this PR, but we have a findAncestor(Class) method in Component class.
It could be useful to have also a findAncestor(Predicate<Component>) for similar cases
There was a problem hiding this comment.
Perhaps if there comes up a need for this.
| getLogger().info( | ||
| "Ignored RPC for invocation handler '{}' from " | ||
| + "the client side for an {} node id='{}' {}", | ||
| getClass().getName(), reason, node.getId(), targetInfo); |
There was a problem hiding this comment.
Both if-else blocks ends with mostly duplicate lines of code so it can be moved out side the if-else blocks in the end of the method and targetInfo could be blank by default.
unify log.
|
tltv
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make log more detailed for
ignored invocation handle.