Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Stop using deprecated fields of v8::FastApiCallbackOptions #192

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[v8] Stop using deprecated fields of v8::FastApiCallbackOptions #192

merged 1 commit into from
Jun 21, 2024

Conversation

gahaas
Copy link

@gahaas gahaas commented Jun 21, 2024

Two fields on the v8::FastApiCallbackOptions struct were deprecated recently, fallback and wasm_memory. This PR removes uses of these two fields in node.js.

This change is a refactoring and does not add new features. Therefore existing tests should be sufficient.

@gahaas gahaas marked this pull request as ready for review June 21, 2024 12:39
isheludko
isheludko approved these changes Jun 21, 2024
View reviewed changes
Copy link

@isheludko isheludko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isheludko isheludko merged commit 286ed38 into v8:node-ci-2024-06-03 Jun 21, 2024
24 of 29 checks passed
@gahaas gahaas deleted the 2024-06-21_fix_name branch June 21, 2024 12:44
gahaas added a commit to gahaas/node that referenced this pull request Jun 24, 2024
@gahaas
Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptio…
d3e11f8 
…ns (v8#192)"

This reverts commit 286ed38.
@gahaas gahaas mentioned this pull request Jun 24, 2024
Open
gahaas added a commit to gahaas/node that referenced this pull request Jun 24, 2024
@gahaas
Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptio…
2fd1ca2 
…ns (v8#192)"

This reverts commit 286ed38.
@gahaas gahaas mentioned this pull request Jun 24, 2024
Merged
victorgomes pushed a commit that referenced this pull request Jun 24, 2024
@gahaas
Reverts #192 (#193)
7f493af 
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
pthier pushed a commit that referenced this pull request Jul 15, 2024
@gahaas
[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)
4ec9e96
pthier pushed a commit that referenced this pull request Jul 15, 2024
@gahaas
Reverts #192 (#193)
ed7f0da 
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
victorgomes added a commit that referenced this pull request Aug 22, 2024
@victorgomes
[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)
167b455 
# Conflicts:
#	src/crypto/crypto_timing.cc
victorgomes pushed a commit that referenced this pull request Aug 22, 2024
@gahaas @victorgomes
Reverts #192 (#193)
346dbbe 
* [wasi] Stop using V8 fast API

* Revert "[wasi] Stop using V8 fast API"

This reverts commit 0d5d171.

* Revert "[v8] Stop using deprecated fields of v8::FastApiCallbackOptions (#192)"

This reverts commit 286ed38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isheludko isheludko isheludko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gahaas @isheludko