Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-site: Replace nunjucks reference #2831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Sep 16, 2024

Summary

Replaced Nunjucks reference with Twig

Related issue

Closes #2809

Preview link

Pagination page

Problem statement

Nunjucks is mentioned in pagination guidance and we no longer use it. We should replace with more general guidance or remove it completely.

Solution

Replaced "Nunjucks" references with "Twig" and added a link to the related source code.

Testing and review

  • Confirm the copy update is appropriate and accurate
  • Confirm the new link points to the correct location

@amyleadem amyleadem marked this pull request as ready for review September 16, 2024 22:51
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I see the related behaviors in the template found at the new link. I think this is likely a better place to point users than including comments they'll need to erase in source code.

Copy link
Contributor

@cathybaptista cathybaptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just feedback. Not a blocker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a preference... I think there isn't a comma after "behaviors below" and before the "and" in this sentence: We've outlined these behaviors below, and included them in the Twig templates for Pagination in our source code. Other than that measly thing, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Documentation: Remove redundant nunjucks reference
3 participants