Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Added radio button accessibility test page #2821

Merged
merged 13 commits into from
Sep 18, 2024
Merged

USWDS-Site: Added radio button accessibility test page #2821

merged 13 commits into from
Sep 18, 2024

Conversation

RachelCorsino
Copy link
Contributor

@RachelCorsino RachelCorsino commented Sep 11, 2024 •
edited
Loading

Summary

Added accessibility test page for radio button component

Related issue

Closes #2800

Preview link

Preview link: Radio Buttons component page

Testing and review

Follow these steps:

  1. Confirm that both the main component page and the accessibility tests page have the correct compliance tag at the top.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page from the accessibility guidance section.
  4. Confirm that the main component page shows the accessibility tests summary.
  5. Check that accessibility tests page provides the correct counts for each test status type.
  6. Confirm the test checklist summaries and data are accurate.
  7. Confirm no visual issues.
  8. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@RachelCorsino RachelCorsino marked this pull request as ready for review September 16, 2024 18:00
@RachelCorsino
Copy link
Contributor Author

@mahoneycm @amyleadem - I'm not seeing the accessibility tests show up on the page... Let me know if you guys notice what I'm missing to make that work! I double checked I put everything in as stated in the Creating Accessibility Checklists doc.

I do see the changelog in the Latest Updates section so at least that's working.

@amyleadem
Copy link
Contributor

@RachelCorsino, to connect the pages, I believe you'll need to rename radio-button.yml to radio-buttons.yml to match the page title. It should build as expected then.

@amyleadem
Copy link
Contributor

Update: I went ahead and updated the file name in 7a9b7f6 so I can review.

amyleadem
amyleadem requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @RachelCorsino. I had just a couple of questions for @alex-hull and @amycole501 below.

_data/accessibility-tests/radio-buttons.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/radio-buttons.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/radio-buttons.yml Outdated Show resolved Hide resolved
_components/radio-buttons/accessibility-tests.md Outdated Show resolved Hide resolved
finekatie
finekatie reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments about possible wording corrections. Looks good otherwise!

_data/accessibility-tests/radio-buttons.yml Outdated Show resolved Hide resolved
_data/accessibility-tests/radio-buttons.yml Outdated Show resolved Hide resolved
finekatie
finekatie approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me!

amyleadem
amyleadem approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

finekatie
finekatie approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I already approved yesterday, but I'll approve again today! LGTM :)

amyleadem
amyleadem reviewed Sep 18, 2024
View reviewed changes
_data/changelogs/component-radio-buttons-accessibility.yml Outdated
title: Radio button accessibility tests
type: component
items:
- date: NNNN-NN-NN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We need to update the changelog dates before merge

@thisisdano thisisdano merged commit ab117c9 into main Sep 18, 2024
10 of 11 checks passed
@thisisdano thisisdano deleted the rc-radio-button-checklist branch September 18, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyleadem amyleadem amyleadem approved these changes

@thisisdano thisisdano thisisdano approved these changes

@amycole501 amycole501 amycole501 approved these changes

@finekatie finekatie finekatie approved these changes

@mahoneycm mahoneycm Awaiting requested review from mahoneycm

@cathybaptista cathybaptista Awaiting requested review from cathybaptista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC a11y: publish radio button checklist - create PR
5 participants
@RachelCorsino @amyleadem @thisisdano @amycole501 @finekatie