USWDS-Site: Added combo box accessibility tests page #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelCorsino
commented
Sep 6, 2024
There was a problem hiding this comment.
@amycole501 and @mahoneycm - There are a few things I wasn't sure about for this checklist and made comments on them in the "Files Changed" tab. Let me know if they are correct or any guidance on what to update would be great!
amyleadem
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Nice work here @RachelCorsino! Everything looks good here. Just had a couple of questions for @amycole501 and @alex-hull.
amyleadem
reviewed
Sep 16, 2024
Co-authored-by: Amy Leadem <[email protected]>
mahoneycm
approved these changes
Sep 16, 2024
amyleadem
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
LGTM - Thanks @RachelCorsino!
@amycole501 or @alex-hull, could you review and confirm that everything appears as expected?
alex-hull
approved these changes
Sep 16, 2024
amycole501
approved these changes
Sep 18, 2024
amyleadem
reviewed
Sep 18, 2024
| title: Combo box accessibility tests | ||
| type: component | ||
| items: | ||
| - date: NNNN-NN-NN |
There was a problem hiding this comment.
Important
We need to update the changelog dates before merge
thisisdano
reviewed
Sep 18, 2024
thisisdano
reviewed
Sep 18, 2024
thisisdano
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added accessibility test page for combo box component
Related issue
Closes #2768
Preview link
Preview link:
Combo Box Component Page
Testing and review
Follow these steps: