Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change join slack button #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

revelcw
Copy link
Contributor

@revelcw revelcw commented Jan 17, 2020

The submit email button looked weird to me so I changed it.

Before

image

After

image

Copy link
Collaborator

@matthew-gerstman matthew-gerstman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Revel!

Thanks so much for opening a PR.

Unfortunately, I'd recommend against merging this one.

The bigger button is easier for touchscreen devices (regardless of screen size) so I'd like to keep it the way it is.

@donavon
Copy link
Contributor

donavon commented Jan 17, 2020

I think the old way (where the button is the same size as the input) looks like 2 input fields. That's always bugged me. In any case, on smaller screen sizes, it reverts back to the old way, so I'm not concerned. Also, the new way isn't a small button, just smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants