Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stylelint checks and checks output consistency #377
Add Stylelint checks and checks output consistency #377
Changes from 12 commits
7e3aaef
716c456
6ba0ca6
12d4edf
e8323b9
0a9492e
1ce0624
0e33e62
ab3a404
9e6adb6
efdedc9
d5ee5cb
4ad180a
100eb41
fe2703c
121137d
93c05a5
036d42b
98685c1
3a011d6
ccdcd97
f7b08fb
2e003d0
ff50c24
7223e6a
8668e22
0f177ff
3a70b0a
bfa325a
f0dbdb4
68f0436
235c684
cab51a4
b70fd5e
ac8c711
58f22fa
1de52df
e27e30f
01e6fe2
31b91f6
01b4935
098ee24
4e0263f
a1834a0
8894a6f
3ab3487
fe92614
4f60f7e
b43292c
1c086c7
49cca45
60fea13
18d25ba
200a1b7
2a7b55f
4341d21
d0d08f4
7f8a26e
85ce0f7
241b7a7
9004208
048811e
b93eaec
9fa5740
3777e9d
42eff47
1c9b999
2807a58
edd7eb6
e4fdce9
c62cb54
e61eb09
b2c8786
aea1845
f12e8a8
2140b0d
b8a2d49
1725584
e26e6b1
5b3f8c5
da0bbac
778935c
f15f743
514f855
90bbed5
393195c
d3e8412
761243f
505c565
b7b1fc8
c2edc82
6f20af3
83189bc
f18804d
bec907d
e9ecf51
560b36a
3b08941
7a1eb7a
1a2ff81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I just realized this is going to be a bug for the Node.js projects
this is what the UpLeveled ESLint Config installer does:
https://github.com/upleveled/eslint-config-upleveled/blob/df447996c8a01039f84489f31161e316be6cddd8/bin/install.js#L51-L53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
098ee24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
31b91f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
31b91f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you could import + use the variable I suggested here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58f22fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the second part of this pattern a valid way to ignore code in Stylelint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
68f0436
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.jsx
here?src/checks/stylelintConfigIsValid.ts
- so that it doesn't get outdated / inconsistent between the two filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58f22fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if there are only errors or only warnings? the ESLint check is intentionally more permissive of a check to avoid this problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0dbdb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if you'll need
normalizeNewline()
and to usestdout
for Windows here like in the ESLint check:preflight/src/checks/eslint.ts
Line 20 in c78424c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0dbdb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.filter()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0dbdb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the PR description with a screenshot of the ESLint check (showing problems in files)?
I think this is inconsistent with the path format of the ESLint check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0dbdb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to
.reduce()
for duplicate filenames? (like we do in the ESLint check) try testing a few different possibilities - I guess probably multiple errors and warnings in a single fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0dbdb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably a merge mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preflight/src/index.ts
Line 94 in 58f22fa