Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stylelint checks and checks output consistency #377

Merged
merged 100 commits into from
Apr 21, 2023
Merged

Add Stylelint checks and checks output consistency #377

Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
7e3aaef
Add stylelint check
Josehower Apr 11, 2023
716c456
Fix function name
Josehower Apr 11, 2023
6ba0ca6
Fix casing on stilelint
Josehower Apr 12, 2023
12d4edf
Merge branch 'main' into add-stylelint-check
Josehower Apr 18, 2023
e8323b9
Add stylelint config validation
Josehower Apr 18, 2023
0a9492e
Add additional file extentions
Josehower Apr 18, 2023
1ce0624
Update test
Josehower Apr 18, 2023
0e33e62
Add exeptions
Josehower Apr 18, 2023
ab3a404
Merge branch 'main' into add-stylelint-check
Josehower Apr 19, 2023
9e6adb6
Add colors
Josehower Apr 19, 2023
efdedc9
Fix error in colors
Josehower Apr 19, 2023
d5ee5cb
Merge branch 'main' into add-stylelint-check
karlhorky Apr 19, 2023
4ad180a
Add icons
Josehower Apr 19, 2023
100eb41
Merge branch 'main' into add-stylelint-check
Josehower Apr 19, 2023
fe2703c
Revert "Add icons"
Josehower Apr 19, 2023
121137d
Add falback renderer
Josehower Apr 19, 2023
93c05a5
Update src/checks/stylelingConfigIsValid.ts
karlhorky Apr 19, 2023
036d42b
Update src/checks/stylelingConfigIsValid.ts
karlhorky Apr 19, 2023
98685c1
Update src/checks/stylelingConfigIsValid.ts
karlhorky Apr 19, 2023
3a011d6
Update snapshot
Josehower Apr 19, 2023
ccdcd97
Merge branch 'main' into add-stylelint-check
karlhorky Apr 19, 2023
f7b08fb
Fix snapshot
karlhorky Apr 19, 2023
2e003d0
Update src/checks/stylelint.ts
karlhorky Apr 19, 2023
ff50c24
Update filename
Josehower Apr 19, 2023
7223e6a
Update src/checks/stylelintConfigIsValid.ts
karlhorky Apr 19, 2023
8668e22
Update e2e.test.ts.snap
karlhorky Apr 19, 2023
0f177ff
Merge branch 'main' into add-stylelint-check
Josehower Apr 19, 2023
3a70b0a
Use yarn until package is updated
Josehower Apr 19, 2023
bfa325a
Update snapshot
Josehower Apr 19, 2023
f0dbdb4
Use Json output format instead of string
Josehower Apr 20, 2023
68f0436
Update string matching stylelint disable
Josehower Apr 20, 2023
235c684
Use pnpm instad of yarn
Josehower Apr 20, 2023
cab51a4
Simplify variable
Josehower Apr 20, 2023
b70fd5e
Fix eslint errors
Josehower Apr 20, 2023
ac8c711
Get type from stylelint
Josehower Apr 20, 2023
58f22fa
Update supported extentions
Josehower Apr 20, 2023
1de52df
Use join() instead of toString()
Josehower Apr 20, 2023
e27e30f
Use version without period
Josehower Apr 20, 2023
01e6fe2
Use Stylelint instead of ESLint
Josehower Apr 20, 2023
31b91f6
Use periodless pattern and add file deletion
Josehower Apr 20, 2023
01b4935
Use parameter
Josehower Apr 20, 2023
098ee24
Add conditional to check react projects
Josehower Apr 20, 2023
4e0263f
Move conditional to the top of the file
Josehower Apr 20, 2023
a1834a0
Update fileExtensions
Josehower Apr 20, 2023
8894a6f
Update variable names
Josehower Apr 20, 2023
3ab3487
Fix indentation and variable names
Josehower Apr 20, 2023
fe92614
Fix capitalization
Josehower Apr 20, 2023
4f60f7e
update variable names
Josehower Apr 20, 2023
b43292c
Update conditional to match codebase
Josehower Apr 20, 2023
1c086c7
Update error message to improve clarity
Josehower Apr 20, 2023
49cca45
Remve unnecesary if exists in message
Josehower Apr 20, 2023
60fea13
Add early return in stylelint check too
Josehower Apr 20, 2023
18d25ba
Update src/checks/stylelint.ts
Josehower Apr 20, 2023
200a1b7
Update src/checks/eslintConfigIsValid.ts
Josehower Apr 20, 2023
2a7b55f
Update src/checks/stylelintConfigIsValid.ts
Josehower Apr 20, 2023
4341d21
Merge branch 'main' into add-stylelint-check
Josehower Apr 20, 2023
d0d08f4
Update command to pnpm
Josehower Apr 20, 2023
7f8a26e
Fix error in command
Josehower Apr 20, 2023
85ce0f7
Update message to match codebase
Josehower Apr 20, 2023
241b7a7
Update src/checks/stylelint.ts
Josehower Apr 20, 2023
9004208
Group and remove checks based on project
Josehower Apr 20, 2023
048811e
Revert "Group and remove checks based on project"
Josehower Apr 20, 2023
b93eaec
Remove stylelint for no react projects
Josehower Apr 20, 2023
9fa5740
Remove extra line
Josehower Apr 20, 2023
3777e9d
Simplify pattern
Josehower Apr 20, 2023
42eff47
Use variable in regex
Josehower Apr 20, 2023
1c9b999
Simplify variable names
Josehower Apr 20, 2023
2807a58
Simplify logic
Josehower Apr 20, 2023
edd7eb6
Simplefy logic
Josehower Apr 20, 2023
e4fdce9
Update path to remove unnecesary extra information
Josehower Apr 20, 2023
c62cb54
Update Snapshot
Josehower Apr 20, 2023
e61eb09
Update prettier output to match pattern
Josehower Apr 20, 2023
b2c8786
Remove unnecesary comments
Josehower Apr 20, 2023
aea1845
Revert "Update Snapshot"
Josehower Apr 21, 2023
f12e8a8
Merge branch 'main' into add-stylelint-check
Josehower Apr 21, 2023
2140b0d
Update eslint check with Json output
Josehower Apr 21, 2023
b8a2d49
Simplify pretier path logic
Josehower Apr 21, 2023
1725584
Update variable name
Josehower Apr 21, 2023
e26e6b1
Use named import
karlhorky Apr 21, 2023
5b3f8c5
Shortcircuit algolia for @upleveled/react-scripts
Josehower Apr 21, 2023
da0bbac
Update src/checks/noDependencyProblems/noDependenciesWithoutTypes.ts
Josehower Apr 21, 2023
778935c
Fix potential break
Josehower Apr 21, 2023
f15f743
Update noDependenciesWithoutTypes.ts
karlhorky Apr 21, 2023
514f855
Fix warning
Josehower Apr 21, 2023
90bbed5
Move comment over the map
Josehower Apr 21, 2023
393195c
Update pattern
Josehower Apr 21, 2023
d3e8412
Simplify path manipulation
karlhorky Apr 21, 2023
761243f
2.1.0-0
karlhorky Apr 21, 2023
505c565
Add Windows paths examples
karlhorky Apr 21, 2023
b7b1fc8
Fix paths, add windows path
karlhorky Apr 21, 2023
c2edc82
Remove obsolete ignored files
karlhorky Apr 21, 2023
6f20af3
Parse the output to do more clear checks
Josehower Apr 21, 2023
83189bc
Update stylelint check and fix errors
Josehower Apr 21, 2023
f18804d
Validate ESLint JSON data for another edge case
karlhorky Apr 21, 2023
bec907d
Improve comment clarity
karlhorky Apr 21, 2023
e9ecf51
Fix spelling error
karlhorky Apr 21, 2023
560b36a
Copy pattern
karlhorky Apr 21, 2023
3b08941
Verify shape of Stylelint data earlier
karlhorky Apr 21, 2023
7a1eb7a
Merge branch 'main' into add-stylelint-check
Josehower Apr 21, 2023
1a2ff81
Merge branch 'main' of github.com:upleveled/preflight into add-stylel…
karlhorky Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions __tests__/__snapshots__/e2e.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ exports[`Passes in the react-passing test project 1`] = `
[COMPLETED] Preflight is latest version
[COMPLETED] Prettier
[COMPLETED] Project folder name matches correct format
[COMPLETED] Stylelint
[COMPLETED] Stylelint config is latest version
[COMPLETED] Use single package manager
[COMPLETED] node_modules/ folder ignored in Git
[STARTED] All changes committed to Git
Expand All @@ -28,6 +30,8 @@ exports[`Passes in the react-passing test project 1`] = `
[STARTED] Preflight is latest version
[STARTED] Prettier
[STARTED] Project folder name matches correct format
[STARTED] Stylelint
[STARTED] Stylelint config is latest version
[STARTED] Use single package manager
[STARTED] node_modules/ folder ignored in Git"
`;
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
]
},
"dependencies": {
"@types/eslint": "8.37.0",
"algoliasearch": "4.17.0",
"chalk": "5.2.0",
"cheerio": "1.0.0-rc.12",
Expand Down Expand Up @@ -88,6 +89,7 @@
"p-map": "5.5.0",
"postinstall-postinstall": "2.1.0",
"size-limit": "8.2.4",
"stylelint": "15.5.0",
karlhorky marked this conversation as resolved.
Show resolved Hide resolved
"tsdx": "0.14.1",
"tslib": "2.5.0",
"typescript": "5.0.4"
Expand Down
Loading