Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg clean up improvements #257

Merged
merged 9 commits into from
May 6, 2024
Merged

Svg clean up improvements #257

merged 9 commits into from
May 6, 2024

Conversation

pedrojesus-work
Copy link
Contributor

@pedrojesus-work pedrojesus-work commented Apr 30, 2024

Fixes: #256

On the first interaction on #219, we thought that should be enough to look up the ContentFilesProjectOutputGroupOutput only, but we ignored the case where the user may have the a svg with the same name used as UnoImage, but in another location, something like:

<UnoImage Include="Assets/Images/car.svg />
<Content Include="Assets/SVG/car.svg" />

On the current version, the SVG/car.svg will not be packaged, because its name matches with the UnoImage version. With this PR the SVG/car.svg will be packaged, because it checks the fullpath.

But still, the same asset can't be used as UnoImage and Content, and this limitation is because we can't know if that was caused by some Uno task or the user want it, and when we have that it could cause unexpected behavior, see #218 for more context on it.

PR Type

  • Bugfix
  • Feature
    What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@pedrojesus-work pedrojesus-work marked this pull request as ready for review April 30, 2024 21:42
@pedrojesus-work
Copy link
Contributor Author

@dansiegel, I believe this will be fixed on unoplatform/uno#16593, but I believe it's a good idea to merge this one, since it improves the look-up on Resizetizer target, but I'll left the decision to you

@dansiegel dansiegel merged commit bc176f8 into main May 6, 2024
9 of 10 checks passed
@dansiegel dansiegel deleted the pj/svg-clean-up-improvements branch May 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .svg formats
2 participants