Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Commit

Permalink
Merge pull request #23 from unchartedsoftware/bugfix/upgrade-handlebars
Browse files Browse the repository at this point in the history
[SECURITY] Fix github vulnerability alert by using the latest Handlebars
  • Loading branch information
psmacmur committed Dec 20, 2017
2 parents e8a5181 + 44a4e7b commit 766ebae
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
8 changes: 5 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ var filter = require('gulp-filter');
var concat = require('gulp-concat');
var runSequence = require('run-sequence');
var sass = require('gulp-sass');
var karma = require('karma')
var karma = require('karma');
var path = require('path');
var fs = require('fs');

Expand Down Expand Up @@ -68,7 +68,7 @@ function doBuild(shouldMinify) {

function doCSS(shouldMinify) {
var build = gulp.src(config.style + '/' + config.name.toLowerCase() + (shouldMinify ? '.min' : '') + '.scss')
.pipe(sass.sync().on('error', sass.logError))
.pipe(sass.sync().on('error', sass.logError));

if (shouldMinify) {
build = build.pipe( minifyCss({ keepSpecialComments: 0 }) );
Expand Down Expand Up @@ -158,7 +158,9 @@ gulp.task('build-extern-css', function() {

gulp.task('build-templates',function() {
return gulp.src(config.templates + '/**/*.hbs')
.pipe(handlebars())
.pipe(handlebars({
handlebars: require('handlebars')
}))
.pipe(defineModule('node'))
.pipe(gulp.dest(config.src + '/templates/'));
});
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Facets Component developed by Uncharted Software",
"repository": "https://github.com/unchartedsoftware/stories-facets",
"license": "Apache-2.0",
"version": "2.12.0",
"version": "2.12.1",
"devDependencies": {
"body-parser": "~1.13.2",
"browserify": "^12.0.1",
Expand All @@ -14,7 +14,7 @@
"cookie-parser": "~1.3.5",
"debug": "~2.2.0",
"express": "~4.13.1",
"gulp": "3.9.0",
"gulp": "3.9.1",
"gulp-concat": "2.6.0",
"gulp-define-module": "0.1.4",
"gulp-filter": "3.0.1",
Expand All @@ -24,8 +24,8 @@
"gulp-order": "1.1.1",
"gulp-sass": "^2.1.0",
"gulp-uglify": "1.4.2",
"handlebars": "3.0.3",
"hbs": "~3.1.0",
"handlebars": "4.0.11",
"hbs": "~4.0.1",
"karma": "^0.13.19",
"karma-browserify": "^5.0.0",
"karma-chai": "^0.1.0",
Expand Down

0 comments on commit 766ebae

Please sign in to comment.