Add batch processing to parseJSONL #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we would be better off multi threading grafer. This approach adds too much complexity to the code and I have the feeling that debugging is going to be even harder, |
|
Yup I agree, I have been investigating how to put together a framework which will allow multithreading using web workers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Solved the biggest contributor to blocking on controller init. 2nd biggest contributor
loadDatanot yet modified.Intends to fix #21
Could also explore the use of web workers as an alternative solution to the batching solution used below. Pros and cons of each strategy should be considered.