Relative points #108
Relative points #108
Conversation
mj3cheun
force-pushed
the
relative-points
branch
from
88b4f5a
to
b317eaa
Compare
mj3cheun
force-pushed
the
relative-points
branch
2 times, most recently
from
5da6a76
to
b3d73ee
Compare
src/data/GraphPoints.ts
Outdated
| import {DataTexture} from '../renderer/DataTexture'; | ||
|
|
||
| export enum ClassModes { |
There was a problem hiding this comment.
HierarchyType instead of ClassModes
mj3cheun
force-pushed
the
relative-points
branch
from
b3d73ee
to
6084097
Compare
mj3cheun
force-pushed
the
relative-points
branch
from
6084097
to
3c0339a
Compare
mj3cheun
force-pushed
the
relative-points
branch
from
cfa1721
to
2bf10a4
Compare
src/data/shaders/GraphPoints.fs.glsl
Outdated
| fragColor = texelFetch(uPointTexture, coords, 0); | ||
|
|
||
| uint i = 0u; | ||
| int classIndex = texelFetch(uParentTexture, coords, 0).x; |
There was a problem hiding this comment.
Rename classIndex to parentIndex
src/data/shaders/classMode.glsl
Outdated
| #define MODE_NONE 0u | ||
| #define MODE_ADD 1u |
There was a problem hiding this comment.
Rename this file to hierarchyType.glsl
| @@ -14,6 +14,7 @@ An array of point objects to be loaded into Grafer. The PointData property list | |||
| | Property | Type | Description | | |||
| | :--- | :--- | :--- | | |||
| | id | string - *optional* | Name of the point. Will be used as an ID when referencing point in node, edge, and label data. Will default to its index in the PointData array if left out. | | |||
| | parentId | string - *optional* | ID of the point which this point is the child of. Used to enable relative positioning of points and relative radius. Will default to *No Parent* if left out. | |||
There was a problem hiding this comment.
ID of the parent point that this point ...
Does it have to be a direct parent, or can it be any ancestor?
There was a problem hiding this comment.
the parentId put in here is the direct parent
| | :--- | :--- | :--- | | ||
| | positionHierarchyType | HierarchyTypes | Changes how point hierarchies changes the point positions. See [HierarchyTypes](./hierarchy-types.md) for more information. | | ||
| | radiusHierarchyType | HierarchyTypes | Changes how point hierarchies changes the point radius. See [HierarchyTypes](./hierarchy-types.md) for more information. | | ||
| | maxHierarchyDepth | number | Sets the maximum hierarchy depth that any point will have. Defaults to 100. | |
There was a problem hiding this comment.
how is the depth used? why is it important? when would I want to change this to be smaller / bigger?
There was a problem hiding this comment.
the maxHierarchyDepth is basically only there to save the user from circular references in the data and stuff like that, which would otherwise crash the os (infinite loop in fragment shader is really not good). this should be increased if you expect the hierarchy depth in the data to be larger than the default value.
| export interface PointData { | ||
| id?: number | string; | ||
| parentId?: number | string; |
There was a problem hiding this comment.
in the readme you state this as a string why and should it also be a number?
There was a problem hiding this comment.
tbh i dunno which is the correct type :(
| @@ -111,28 +167,38 @@ export class GraphPoints extends DataTexture { | |||
| return this.map.get(id); | |||
| } | |||
|
|
|||
| public getPointByIndex(index: number): [number, number, number, number] { | |||
| public getPointByIndex(index: number, isRelative = false): [number, number, number, number] { | |||
| if(isRelative) { | |||
There was a problem hiding this comment.
is this correct? should the old logic be run when it is relative? seems reversed
There was a problem hiding this comment.
in my opinion no, because the function (the way it worked before) makes the assumption that the points returned are relative to the world space origin. this is incredibly important for stuff like tooltips etc. if we were to break this assumption we will be breaking a lot of stuff.
a small example was added |
No description provided.